Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external_storage_configuration_gui.rst #1926

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

joshmorel
Copy link
Contributor

To resolve #1925

@skjnldsv This updates the screenshots to remove Dropbox etc - it definitely applies back to 16. Not sure about 15.

I noticed "Mount options" is also quite different with v16+ so I changed that in the 2nd commit of this PR:

image

Nothing else seemed too different (some screenshots with older design but similar enough) however maybe a quick look through by the main person responsible for with apps/files_external might be worthwhile?

@welcome
Copy link

welcome bot commented Mar 31, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@skjnldsv
Copy link
Member

Ah wait, we merged a bit too fast ^^'

@joshmorel where are your new images used in the docs? I don't see any reference so far?

@joshmorel
Copy link
Contributor Author

@skjnldsv

All the new images - are replacing existing files referenced in:

https://github.com/nextcloud/documentation/blob/master/admin_manual/configuration_files/external_storage_configuration_gui.rst

Lines:
33: .. figure:: external_storage/images/add_storage.png
91: .. figure:: external_storage/images/mount_options.png
131: .. figure:: external_storage/images/user_mounts.png

@skjnldsv
Copy link
Member

Ah sorry, I misunderstood github, I thought those were new files, not modified ones! All good! 😁
Thanks a lot for this!

@joshmorel
Copy link
Contributor Author

@skjnldsv

NP. Like #1891 this can be backported to v16. I supposed to call those slash commands as the contributor or you as the maintainer?

@skjnldsv
Copy link
Member

@joshmorel you can also do it by commenting like this

/backport to stable18

@skjnldsv
Copy link
Member

/backport to stable17

@skjnldsv
Copy link
Member

/backport to stable16

@backportbot-nextcloud
Copy link

backport to stable18 in #1928

@backportbot-nextcloud
Copy link

backport to stable17 in #1929

@backportbot-nextcloud
Copy link

backport to stable16 in #1930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update external storage images
4 participants