Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of some wordings (clearer and more consistent) #155

Closed

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Nov 16, 2023

Check commits :

Settings : Because "local" is not appropriate. The goal of the app is to generate download notification for files that are shared locally = shared with local users or groups (not external shares).

Provider : Because wordings had a lack of consistency width existing others.

Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this a bit more concise, all of the "downloaded by" can do without "the":

  • via desktop client
  • via mobile app
  • via browser

@nickvergessen
Copy link
Member

This app is not being released anymore as per #135

So changing the strings will also not have any effect, unless someone takes over ownership

@nickvergessen nickvergessen deleted the Jerome-Herbinet-some-wordings-improvements branch November 22, 2023 13:31
@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Nov 22, 2023

@nickvergessen one question anyway : Are you aware of any plans for Nextcloud to take over this app's features (which we think are interesting, although the wordings could be improved) and incorporate them directly into "Activity"? If not, how would you feel about promoting this idea within the development teams?
cc @jancborchardt

@nickvergessen
Copy link
Member

Are you aware of any plans for Nextcloud to take over this app's features (which we think are interesting, although the wordings could be improved) and incorporate them directly into "Activity"?

No

If not, how would you feel about promoting this idea within the development teams?

I don't have the time nor energy for this and the general download counter of this app also doesn't sound like lot of people agree.

@Jerome-Herbinet
Copy link
Member Author

Are you aware of any plans for Nextcloud to take over this app's features (which we think are interesting, although the wordings could be improved) and incorporate them directly into "Activity"?

No

If not, how would you feel about promoting this idea within the development teams?

I don't have the time nor energy for this and the general download counter of this app also doesn't sound like lot of people agree.

OK thanks for the answer, it was just a question 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants