Add missing S3 parameters #614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
added
3. to review
|
oops, forgot to update the README. Let me do that 🤦 Edit: done. |
jessebot
force-pushed
the
fix-missing-env-vars
branch
from
6bfbed6
to
08c8e03
Compare
|
Taking a look at why the test failed now 🤔 (edit: was a typo, is now fixed) |
Signed-off-by: jessebot <[email protected]>
jessebot
force-pushed
the
fix-missing-env-vars
branch
from
08c8e03
to
fba5840
Compare
|
As I said in #613 (comment) I feel it is better to let upstream confirm the changes since they know best how to do this stuff. You already mentioned the config files being out of sync can cause confusion and I'd like to avoid that. |
jessebot
added
blocked - upstream
wrenix
reviewed
Sep 21, 2024
jessebot
commented
Sep 24, 2024
don't set defaults as they're already set in values.yaml Signed-off-by: Jesse Hitch <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds the remaining variables that are due to eventually be added in the upstream nextcloud/docker#2271. All of these parameters are documented here.
Benefits
Now users will be able to set every single documented Nextcloud S3 parameter, even if it's not yet supported in the docker image upstream.
Possible drawbacks
Some of these env vars are not yet merged in the docker container repo, which may cause some confusion, but shouldn't make a difference overall.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.