-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextcloud): add support of imaginary an externalPreviewProvider #622
base: main
Are you sure you want to change the base?
Conversation
6ace176
to
44beda3
Compare
04d871c
to
5b0fc90
Compare
ping @jessebot / @provokateurin do you like to review? |
Sorry, I don't have the time for that atm. I hope I can do it at some point, but only at the beginning of next month the earliest. |
5b0fc90
to
13cba3b
Compare
oh this is neat! May I ask what the difference between this and the preview generator app are? (I'm not against it btw, just want to learn more) I will review this more thoroughly as soon as I have a moment 🙏 |
4389148
to
0c32ab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this! Perhaps we can add another PR for adding a CI test of some sort in the future?
Thank you for working on this 🚀 |
Signed-off-by: WrenIX <[email protected]>
Co-authored-by: Jesse Hitch <[email protected]> Signed-off-by: WrenIX <[email protected]>
490e772
to
fd741c3
Compare
rebased on main and add docu in e393d90 like @SIMULATAN suggested |
Signed-off-by: WrenIX <[email protected]>
fd741c3
to
e393d90
Compare
Description of the change
Benefits
Possible drawbacks
Works for me.
TODO:
Checklist
Chart.yaml
according to semver.