-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm and node engines versions #194
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm 👍 @individual-it @eneiluj should we merge this?
that will simply require node 16 for building the extension, or will anything break? |
yes, the engine requirement should be fulfilled for the building purpose. but not sure if anything breaks. One good thing is that current tests are happy at least. |
64124e4
to
5d03f27
Compare
Signed-off-by: nextcloud-command <[email protected]>
5d03f27
to
0cd83ba
Compare
JS Code CoverageCoverage after merging feat/package-node-npm-engines-update into master will be
Coverage Report |
Automated update of the npm and node engines versions