Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use <tfoot> for "loading older entries" row #948

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 21, 2023

Follow up on #936

As discussed the "loading more entries" / "no more entries" row (the intersection observer) should be on the tfoot for accessibility.

@susnux susnux requested a review from Pytal July 21, 2023 23:22
@susnux susnux marked this pull request as ready for review July 21, 2023 23:22
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +57.73% 🎉

Comparison is base (a98b582) 42.26% compared to head (2bf3443) 100.00%.

❗ Current head 2bf3443 differs from pull request most recent head a460cc5. Consider uploading reports for the commit a460cc5 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             master      #948       +/-   ##
==============================================
+ Coverage     42.26%   100.00%   +57.73%     
==============================================
  Files            23        10       -13     
  Lines           601       168      -433     
  Branches         31        31               
==============================================
- Hits            254       168       -86     
+ Misses          347         0      -347     
Flag Coverage Δ
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux
Copy link
Contributor Author

susnux commented Jul 24, 2023

/compile amend

…rver)

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 3200e6c into master Jul 24, 2023
21 checks passed
@susnux susnux deleted the fix/use-tfoot-for-a11y branch July 24, 2023 22:44
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants