style: change parameter style to avoid_final_parameters #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer a single style for all packages. Either remove them everywhere or keep them everywhere. |
|
Can we still do this incrementally? |
|
Sure |
provokateurin
requested changes
Dec 20, 2023
I disagree. While I will try to tackle this in the coming days the individual migrations (especially the framework) will take some time. If we where to introduce a new package in that time it should automatically have the new rules. |
|
Ok I get that point. Then please add a TODO comment everywhere where the rules are manually changed. |
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
style/change-lint-rules
branch
from
cba9fee
to
1ecb4d8
Compare
provokateurin
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1245
This does not migrate all of our packages and I don't see the need to do this any time soon.
For the bigger ones like dynamite or the framework we could also just keep it for ever.