Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): rewrite login flow and account handling #2407

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Aug 19, 2024

.

@provokateurin
Copy link
Member

The following UnsupportedError was thrown running a test:
Unsupported operation: The fake account client can not be used in tests.

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/rewrite_login_flow branch from 92c64a1 to 4ec1734 Compare August 19, 2024 10:14
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 86.84720% with 68 lines in your changes missing coverage. Please review.

Project coverage is 30.29%. Comparing base (c07d612) to head (26dca5d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...n_check_account/view/login_check_account_view.dart 51.72% 14 Missing ⚠️
...lib/src/login_qr_code/view/login_qr_code_view.dart 8.33% 11 Missing ⚠️
packages/neon_framework/lib/src/router.dart 35.71% 9 Missing ⚠️
...ackages/neon_framework/lib/src/blocs/accounts.dart 0.00% 8 Missing ⚠️
.../neon_framework/lib/src/login/view/login_view.dart 88.57% 8 Missing ⚠️
...lib/src/login_qr_code/view/login_qr_code_page.dart 16.66% 5 Missing ⚠️
packages/neon_framework/lib/src/widgets/error.dart 16.66% 5 Missing ⚠️
packages/neon_framework/lib/src/router.g.dart 40.00% 3 Missing ⚠️
...ib/src/login_qr_code/bloc/login_qr_code_event.dart 71.42% 2 Missing ⚠️
.../neon_framework/lib/src/login/bloc/login_bloc.dart 96.29% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
+ Coverage   29.91%   30.29%   +0.38%     
==========================================
  Files         332      352      +20     
  Lines      124382   124361      -21     
==========================================
+ Hits        37205    37672     +467     
+ Misses      87177    86689     -488     
Flag Coverage Δ *Carryforward flag
account_repository 98.77% <ø> (-0.87%) ⬇️
cookie_store 99.48% <ø> (ø) Carriedforward from c07d612
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from c07d612
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from c07d612
dynamite_runtime 85.40% <ø> (ø) Carriedforward from c07d612
neon_dashboard 96.05% <ø> (ø) Carriedforward from c07d612
neon_framework 57.10% <86.84%> (+13.52%) ⬆️
neon_http_client 96.69% <ø> (ø) Carriedforward from c07d612
neon_notifications 100.00% <ø> (ø) Carriedforward from c07d612
neon_talk 99.45% <ø> (ø) Carriedforward from c07d612
nextcloud 25.90% <ø> (ø) Carriedforward from c07d612
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from c07d612
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...neon_framework/lib/src/login/bloc/login_event.dart 100.00% <100.00%> (ø)
...neon_framework/lib/src/login/bloc/login_state.dart 100.00% <100.00%> (ø)
...n_check_account/bloc/login_check_account_bloc.dart 100.00% <100.00%> (ø)
..._check_account/bloc/login_check_account_event.dart 100.00% <100.00%> (ø)
..._check_account/bloc/login_check_account_state.dart 100.00% <100.00%> (ø)
...n_check_account/view/login_check_account_page.dart 100.00% <100.00%> (ø)
...gin_check_server/bloc/login_check_server_bloc.dart 100.00% <100.00%> (ø)
...in_check_server/bloc/login_check_server_event.dart 100.00% <100.00%> (ø)
...in_check_server/bloc/login_check_server_state.dart 100.00% <100.00%> (ø)
...gin_check_server/view/login_check_server_page.dart 100.00% <100.00%> (ø)
... and 25 more

... and 8 files with indirect coverage changes

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it myself yet, but it looks very promising.
I have to agree this is a very clean approach for separation of concerns and seems fairly scalable.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read through every change, but I'll trust you that it's good.
I only found two minor things that you might want to fix.

@provokateurin
Copy link
Member

Really awesome work btw ❤️

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/rewrite_login_flow branch from 6870346 to 26dca5d Compare September 12, 2024 21:36
@Leptopoda Leptopoda merged commit bff33e8 into main Sep 13, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/neon_framework/rewrite_login_flow branch September 13, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants