-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(neon_framework): rewrite login flow and account handling #2407
Conversation
|
92c64a1
to
4ec1734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it myself yet, but it looks very promising.
I have to agree this is a very clean approach for separation of concerns and seems fairly scalable.
packages/neon_framework/test/login_check_account/view/login_check_account_page_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/test/login_check_account/view/login_check_account_page_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/test/login_flow_v2/bloc/login_flow_v2_bloc_test.dart
Show resolved
Hide resolved
packages/neon_framework/test/login_qr_code/view/login_qr_code_page_test.dart
Outdated
Show resolved
Hide resolved
4ec1734
to
9c04310
Compare
a951c03
to
6870346
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read through every change, but I'll trust you that it's good.
I only found two minor things that you might want to fix.
Really awesome work btw ❤️ |
Signed-off-by: Nikolas Rimikis <[email protected]>
6870346
to
26dca5d
Compare
.