Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency flutter to v3.24.2 #2452

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

provokateurin
Copy link
Member

Continuation of #2399
Fixes #2391

@provokateurin
Copy link
Member Author

Ok flutter beta doesn't actually fix it for CI?!

@provokateurin provokateurin marked this pull request as draft September 1, 2024 05:24
@provokateurin provokateurin changed the title chore(deps): update dependency flutter to v3.25.0-0.1.pre chore(deps): update dependency flutter to v3.24.2 Sep 5, 2024
@provokateurin
Copy link
Member Author

Locally it works, let's see what CI has to say...

@provokateurin
Copy link
Member Author

It seems to work finally!

@provokateurin provokateurin marked this pull request as ready for review September 5, 2024 04:50
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 29.92%. Comparing base (1265f22) to head (64ca2f1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/neon_framework/lib/src/pages/home.dart 0.00% 6 Missing ⚠️
...kages/neon_framework/lib/src/pages/login_flow.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
+ Coverage   27.20%   29.92%   +2.71%     
==========================================
  Files         369      332      -37     
  Lines      136655   124414   -12241     
==========================================
+ Hits        37179    37231      +52     
+ Misses      99476    87183   -12293     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 99.48% <ø> (-0.52%) ⬇️
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 1265f22
neon_framework 43.65% <0.00%> (-0.04%) ⬇️
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 1265f22
neon_talk 99.45% <ø> (ø) Carriedforward from 1265f22
nextcloud 25.90% <ø> (+2.64%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 99.09% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/neon_framework/lib/src/utils/global_options.dart 0.00% <ø> (ø)
...ackages/neon_framework/lib/src/widgets/drawer.dart 62.96% <ø> (ø)
...ramework/packages/talk_app/lib/src/pages/room.dart 100.00% <100.00%> (ø)
packages/neon_framework/lib/src/pages/home.dart 0.00% <0.00%> (ø)
...kages/neon_framework/lib/src/pages/login_flow.dart 0.00% <0.00%> (ø)

... and 45 files with indirect coverage changes

@provokateurin provokateurin merged commit 187b509 into main Sep 5, 2024
9 of 10 checks passed
@provokateurin provokateurin deleted the chore/deps/flutter branch September 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken analysis in neon_framework with Dart 3.5
2 participants