Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications_app): Display rich notifications #2456

Merged
merged 4 commits into from
Sep 28, 2024
Merged

feat(notifications_app): Display rich notifications #2456

merged 4 commits into from
Sep 28, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Aug 31, 2024 •
edited
Loading

Closes #212

@codecov Codecov
Copy link

codecov bot commented Aug 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.70115% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.52%. Comparing base (08d4702) to head (c81a183).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...otifications_app/lib/src/widgets/notification.dart 90.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2456      +/-   ##
==========================================
+ Coverage   28.50%   28.52%   +0.01%     
==========================================
  Files         354      355       +1     
  Lines      135984   136003      +19     
==========================================
+ Hits        38768    38794      +26     
+ Misses      97216    97209       -7
Flag Coverage Δ *Carryforward flag
account_repository 98.76% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 08d4702
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 08d4702
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 08d4702
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 08d4702
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 08d4702
neon_dashboard 96.05% <ø> (ø) Carriedforward from 08d4702
neon_framework 59.27% <100.00%> (+2.19%) ⬆️
neon_http_client 97.50% <ø> (ø) Carriedforward from 08d4702
neon_notifications 100.00% <ø> (ø) Carriedforward from 08d4702
neon_talk 99.45% <ø> (ø) Carriedforward from 08d4702
nextcloud 24.26% <ø> (ø) Carriedforward from 08d4702
notifications_app 97.40% <90.00%> (-2.60%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from 08d4702
talk_app 98.94% <100.00%> (-0.15%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...framework/lib/src/widgets/rich_text/deck_card.dart 100.00% <100.00%> (ø)
..._framework/lib/src/widgets/rich_text/fallback.dart 100.00% <100.00%> (ø)
...neon_framework/lib/src/widgets/rich_text/file.dart 100.00% <100.00%> (ø)
...n_framework/lib/src/widgets/rich_text/mention.dart 100.00% <100.00%> (ø)
...framework/lib/src/widgets/rich_text/rich_text.dart 100.00% <100.00%> (ø)
...ork/packages/talk_app/lib/src/widgets/message.dart 98.80% <100.00%> (-0.21%) ⬇️
...otifications_app/lib/src/widgets/notification.dart 95.65% <90.00%> (-4.35%) ⬇️

... and 3 files with indirect coverage changes

@provokateurin provokateurin force-pushed the feat/notifications_app/rich-notifications branch from f6a03dd to c0193a7 Compare September 8, 2024 08:29
@provokateurin provokateurin added this to the Nextcloud 8.0.0 release milestone Sep 14, 2024
@provokateurin provokateurin marked this pull request as draft September 15, 2024 08:39
@provokateurin provokateurin mentioned this pull request Sep 15, 2024
Merged
@provokateurin provokateurin removed this from the Nextcloud 8.0.0 release milestone Sep 15, 2024
@provokateurin provokateurin force-pushed the feat/notifications_app/rich-notifications branch from c0193a7 to b288377 Compare September 16, 2024 20:13
@provokateurin provokateurin marked this pull request as ready for review September 16, 2024 20:13
@provokateurin provokateurin force-pushed the feat/notifications_app/rich-notifications branch from b288377 to c81a183 Compare September 28, 2024 17:52
@provokateurin provokateurin merged commit 44f520b into main Sep 28, 2024
10 checks passed
@provokateurin provokateurin deleted the feat/notifications_app/rich-notifications branch September 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support rich notifications
2 participants
@provokateurin @Leptopoda