Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix rich parameter typing for broken apps #2501

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

provokateurin
Copy link
Member

Split off from #2456

I squashed the previously separate commits as they need each other to make sense.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, that we lose the typing on the spreed and notifications :(
LGTM overall, please just address the small parsing issue.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 9.12779% with 448 lines in your changes missing coverage. Please review.

Project coverage is 28.37%. Comparing base (2abdd80) to head (f4fd9cf).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ges/nextcloud/lib/src/api/core/core.openapi.g.dart 0.24% 402 Missing ⚠️
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 25.00% 18 Missing ⚠️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 37.03% 17 Missing ⚠️
...src/api/notifications/notifications.openapi.g.dart 33.33% 8 Missing ⚠️
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   30.27%   28.37%   -1.90%     
==========================================
  Files         352      352              
  Lines      124321   135904   +11583     
==========================================
+ Hits        37632    38560     +928     
- Misses      86689    97344   +10655     
Flag Coverage Δ *Carryforward flag
account_repository 98.77% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 2abdd80
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 2abdd80
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 2abdd80
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 2abdd80
neon_dashboard 96.05% <ø> (ø) Carriedforward from 2abdd80
neon_framework 57.07% <ø> (ø)
neon_http_client 96.69% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 2abdd80
neon_talk 99.45% <ø> (ø) Carriedforward from 2abdd80
nextcloud 24.14% <5.88%> (-1.74%) ⬇️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 2abdd80
talk_app 99.09% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ork/packages/talk_app/lib/src/widgets/message.dart 99.00% <100.00%> (+<0.01%) ⬆️
...alk_app/lib/src/widgets/rich_object/deck_card.dart 100.00% <ø> (ø)
...talk_app/lib/src/widgets/rich_object/fallback.dart 100.00% <ø> (ø)
...ges/talk_app/lib/src/widgets/rich_object/file.dart 100.00% <100.00%> (ø)
.../talk_app/lib/src/widgets/rich_object/mention.dart 100.00% <100.00%> (ø)
...b/src/api/notifications/notifications.openapi.dart 56.02% <100.00%> (-4.60%) ⬇️
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 14.38% <66.66%> (-0.81%) ⬇️
...src/api/notifications/notifications.openapi.g.dart 30.68% <33.33%> (-3.31%) ⬇️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 39.99% <37.03%> (-5.46%) ⬇️
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 32.29% <25.00%> (-0.85%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

… rich parameter typing for broken apps

Signed-off-by: provokateurin <[email protected]>
@provokateurin provokateurin merged commit cd20549 into main Sep 15, 2024
8 of 10 checks passed
@provokateurin provokateurin deleted the fix/nextcloud/rich-objects branch September 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants