-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextcloud)!: Throw DynamiteStatusCodeExceptions for invalid WebDAV status codes #2475
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
=======================================
Coverage 30.29% 30.29%
=======================================
Files 352 352
Lines 124360 124389 +29
=======================================
+ Hits 37671 37680 +9
- Misses 86689 86709 +20
*This pull request uses carry forward flags. Click here to find out more.
|
29b5598
to
34ffd7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure about the first commit.
Maybe we should wait with any refactors in that regard until we've decided on how we tackle other webdav based clients.
I think any refactor to support CalDAV and CardDAV will need this even more as the clients get even more different from the generated ones by extending the base DAV client in some form (e.g. polymorphism or some other way). But yeah I can drop it from here as it is not necessary for the second commit and only an internal refactor that isn't breaking anyone so it can be done at any point. |
…V status codes Signed-off-by: provokateurin <[email protected]>
34ffd7a
to
801599c
Compare
Fixes #2307