Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): rename credentials password to appPassowrd #2488

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Sep 12, 2024

As discussed in the initial account_repository PR (#2403 (comment)).

Base automatically changed from refactor/neon_framework/rewrite_login_flow to main September 13, 2024 03:26
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loginName and username can not be mixed and we need both.

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/rename_credential_parameters branch from ff5ce04 to 5addca0 Compare September 15, 2024 09:28
@Leptopoda
Copy link
Member Author

I just dropped the login name change and will fix that in the UserDetails bloc refactor.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.26%. Comparing base (801599c) to head (5addca0).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
packages/neon_framework/lib/src/widgets/error.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
- Coverage   30.29%   30.26%   -0.03%     
==========================================
  Files         352      352              
  Lines      124389   124320      -69     
==========================================
- Hits        37680    37631      -49     
+ Misses      86709    86689      -20     
Flag Coverage Δ *Carryforward flag
account_repository 98.76% <100.00%> (-0.01%) ⬇️
cookie_store 99.48% <ø> (ø) Carriedforward from 801599c
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 801599c
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 801599c
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 801599c
neon_dashboard 96.05% <ø> (ø) Carriedforward from 801599c
neon_framework 57.07% <75.00%> (-0.03%) ⬇️
neon_http_client 96.69% <ø> (ø) Carriedforward from 801599c
neon_notifications 100.00% <ø> (ø) Carriedforward from 801599c
neon_talk 99.45% <ø> (ø) Carriedforward from 801599c
nextcloud 25.88% <ø> (-0.03%) ⬇️ Carriedforward from 801599c
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 801599c
talk_app 99.09% <100.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...es/neon_framework/lib/src/testing/mock_server.dart 90.00% <ø> (ø)
packages/neon_framework/lib/src/testing/mocks.dart 92.30% <ø> (ø)
...mework/lib/src/utils/account_client_extension.dart 100.00% <100.00%> (ø)
...account_repository/lib/src/account_repository.dart 100.00% <100.00%> (ø)
...ges/account_repository/lib/src/models/account.dart 100.00% <ø> (ø)
...account_repository/lib/src/models/credentials.dart 100.00% <ø> (ø)
...count_repository/lib/src/models/credentials.g.dart 100.00% <100.00%> (ø)
...count_repository/lib/src/models/login_qr_code.dart 100.00% <100.00%> (ø)
...epository/lib/src/testing/testing_credentials.dart 100.00% <100.00%> (ø)
..._repository/lib/src/utils/http_client_builder.dart 100.00% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

@Leptopoda Leptopoda merged commit c95309b into main Sep 15, 2024
9 of 10 checks passed
@Leptopoda Leptopoda deleted the refactor/neon_framework/rename_credential_parameters branch September 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants