test(nextcloud): Add checks to ensure that all available props are parsed #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
test/nextcloud/all-props-parsed
branch
from
4ae9f68
to
548176b
Compare
provokateurin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
+ Coverage 28.79% 28.83% +0.04%
==========================================
Files 370 370
Lines 136490 136478 -12
==========================================
+ Hits 39296 39359 +63
+ Misses 97194 97119 -75
*This pull request uses carry forward flags. Click here to find out more. |
Leptopoda
reviewed
Oct 19, 2024
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…arsed Signed-off-by: provokateurin <[email protected]>
…rsed Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
test/nextcloud/all-props-parsed
branch
from
548176b
to
866e261
Compare
Leptopoda
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to become a lot more useful when sabre-io/dav#1564 is merged and in a released Nextcloud version, as we are currently missing out on a lot of props when requesting all available props.