-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextcloud): Fix WebDav path calculations for instances hosted at subpaths #2562
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2562 +/- ##
=======================================
Coverage 28.67% 28.67%
=======================================
Files 366 366
Lines 136296 136299 +3
=======================================
+ Hits 39077 39079 +2
- Misses 97219 97220 +1
*This pull request uses carry forward flags. Click here to find out more.
|
LGTM but still missing some unit tests |
0449141
to
3eaa429
Compare
I didn't add tests for everything given that I will remove most of them in #2561, so I only added tests for what will stay. |
…subpaths Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
3eaa429
to
d68f74a
Compare
Might fix saber-notes/saber#772