Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database prefix #1889

Merged
merged 2 commits into from
May 4, 2024
Merged

Fix database prefix #1889

merged 2 commits into from
May 4, 2024

Conversation

janvlug
Copy link
Contributor

@janvlug janvlug commented Mar 31, 2024

This fixes issue #1818 by getting the database prefix from the configuration file and using it in the SQL command that failed because of a hard coded database prefix.

Signed-off-by: Jan Vlug <[email protected]>
Copy link
Collaborator

@theCalcaholic theCalcaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Apart from the typo and the quoting it looks good to me and I will merge and test the change once those have been fixed :)

bin/ncp-update-nc Outdated Show resolved Hide resolved
Co-authored-by: Tobias Knöppler <[email protected]>
Signed-off-by: Jan Vlug <[email protected]>
Copy link
Collaborator

@theCalcaholic theCalcaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm now

@theCalcaholic theCalcaholic merged commit a6c4b24 into nextcloud:devel May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants