Merge pull request #2663 from nextcloud/artonge/backport/stable27/2658

[stable27] feat: Check upload directory share state

lib/Controller/PageController.php

@@ -107,12 +107,20 @@ public function index(): TemplateResponse {
 		$this->eventDispatcher->dispatch(LoadSidebar::class, new LoadSidebar());
 		$this->eventDispatcher->dispatch(LoadViewer::class, new LoadViewer());
 
+		$userFolder = $this->rootFolder->getUserFolder($user->getUid());
+		try {
+			$photosFolder = $userFolder->get($this->userConfig->getUserConfig('photosLocation'));
+		} catch (NotFoundException $e) {
+			$photosFolder = $userFolder->newFolder($this->userConfig->getUserConfig('photosLocation'));
+		}
+
 		$this->initialState->provideInitialState('image-mimes', Application::IMAGE_MIMES);
 		$this->initialState->provideInitialState('video-mimes', Application::VIDEO_MIMES);
 		$this->initialState->provideInitialState('maps', $this->appManager->isEnabledForUser('maps') === true);
 		$this->initialState->provideInitialState('recognize', $this->appManager->isEnabledForUser('recognize') === true);
 		$this->initialState->provideInitialState('systemtags', $this->appManager->isEnabledForUser('systemtags') === true);
 		$this->initialState->provideInitialState('showPeopleMenuEntry', $this->config->getAppValue('photos', 'showPeopleMenuEntry', 'true') === 'true');
+		$this->initialState->provideInitialState('photosLocationOwner', $photosFolder->getOwner()->getUid());
 
 		// Provide user config
 		foreach (array_keys(UserConfigService::DEFAULT_CONFIGS) as $key) {

lib/Sabre/Album/AlbumRoot.php

@@ -29,6 +29,7 @@
 use OCA\Photos\Album\AlbumWithFiles;
 use OCA\Photos\Service\UserConfigService;
 use OCP\Files\Folder;
+use OCP\Files\InvalidDirectoryException;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotFoundException;
 use Sabre\DAV\Exception\Conflict;
@@ -106,6 +107,10 @@ public function createFile($name, $data = null) {
 				throw new Conflict('The destination exists and is not a folder');
 			}
 
+			if ($photosFolder->isShared()) {
+				throw new InvalidDirectoryException('The destination is a received share');
+			}
+
 			// Check for conflict and rename the file accordingly
 			$newName = \basename(\OC_Helper::buildNotExistingFileName($photosLocation, $name));
 

src/components/FilesPicker.vue

@@ -62,26 +62,32 @@
 		</div>
 
 		<div class="file-picker__actions">
-			<UploadPicker :accept="allowedMimes"
-				:context="uploadContext"
-				:destination="photosLocation"
-				:multiple="true"
-				@uploaded="refreshFiles"
-				@failed="handleFailure" />
-			<NcButton type="primary" :disabled="loading || selectedFileIds.length === 0" @click="emitPickedEvent">
-				<template #icon>
-					<ImagePlus v-if="!loading" />
-					<NcLoadingIcon v-if="loading" />
-				</template>
-				{{ t('photos', 'Add to {destination}', { destination }) }}
-			</NcButton>
+			<div class="file-picker__actions__buttons">
+				<UploadPicker :accept="allowedMimes"
+					:context="uploadContext"
+					:destination="photosLocation"
+					:multiple="true"
+					@uploaded="refreshFiles"
+					@failed="handleFailure" />
+				<NcButton type="primary" :disabled="loading || selectedFileIds.length === 0" @click="emitPickedEvent">
+					<template #icon>
+						<ImagePlus v-if="!loading" />
+						<NcLoadingIcon v-if="loading" />
+					</template>
+					{{ t('photos', 'Add to {destination}', { destination }) }}
+				</NcButton>
+			</div>
+			<NcNoteCard v-if="photosLocationOwner !== currentUser" type="warning">
+				{{ t('photos', 'The destination folder is owned by {owner}', { owner: photosLocationOwner }) }}
+			</NcNoteCard>
 		</div>
 	</div>
 </template>
 
 <script>
 import { mapGetters } from 'vuex'
-import { NcButton, NcLoadingIcon } from '@nextcloud/vue'
+import { NcButton, NcLoadingIcon, NcNoteCard } from '@nextcloud/vue'
+import { getCurrentUser } from '@nextcloud/auth'
 import { UploadPicker } from '@nextcloud/upload'
 import moment from '@nextcloud/moment'
 
@@ -106,6 +112,7 @@ export default {
 		ImagePlus,
 		NcButton,
 		NcLoadingIcon,
+		NcNoteCard,
 		UploadPicker,
 	},
 
@@ -151,6 +158,7 @@ export default {
 			uploadContext: {
 				route: 'albumpicker',
 			},
+			currentUser: getCurrentUser().uid,
 		}
 	},
 
@@ -268,9 +276,18 @@ export default {
 
 	&__actions {
 		display: flex;
+		flex-direction: column;
 		justify-content: space-between;
 		justify-items: center;
 		padding-top: 16px;
+		flex-grow: 1;
+
+		&__buttons {
+			display: flex;
+			align-items: center;
+			justify-content: end;
+			gap: 16px;
+		}
 	}
 }
 </style>

src/mixins/UserConfig.js

@@ -36,6 +36,7 @@ export default {
 				? croppedLayoutLocalStorage === 'true'
 				: loadState('photos', 'croppedLayout', 'false') === 'true',
 			photosLocation: loadState('photos', 'photosLocation', ''),
+			photosLocationOwner: loadState('photos', 'photosLocationOwner', ''),
 		}
 	},