enh(faces): Avoid O(n) API calls on faces overview #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Jun 12, 2023
marcelklehr
force-pushed
the
enh/use-faces-props-in-overview
branch
from
84ca174
to
b9c1174
Compare
|
/compile |
marcelklehr
force-pushed
the
enh/use-faces-props-in-overview
branch
2 times, most recently
from
75ef862
to
6a4cef9
Compare
|
@artonge Argh, it doesn't accept my manual build. What do we do now? |
|
Have you |
|
Yes |
|
Then might be a difference in node or npm version |
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/use-faces-props-in-overview
branch
from
6a4cef9
to
fbbfd6a
Compare
|
/compile |
Signed-off-by: Marcel Klehr <[email protected]>
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled by nextcloud/recognize@45fe176