Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: welcome typescript and refactor folders store #2585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: welcome typescript and refactor folders store #2585

wants to merge 1 commit into from
+851 −413

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 8, 2024 •
edited
Loading

Fix #2067

  • Migrate folders store to pinia to solve reactivity issue
  • Migrate to typescript part 1

Followups

  • Keep migrating other stores
  • More typescript

@skjnldsv skjnldsv changed the base branch from master to fix/folders-empty August 8, 2024 10:04
@skjnldsv skjnldsv marked this pull request as ready for review August 8, 2024 10:38
@skjnldsv skjnldsv self-assigned this Aug 8, 2024
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature technical debt Technical issue labels Aug 8, 2024
@skjnldsv skjnldsv requested review from susnux, artonge, ShGKme, a team and szaimen and removed request for a team August 8, 2024 10:38
@susnux
Copy link
Contributor

susnux commented Aug 8, 2024

see also #2312 :)

@szaimen szaimen removed their request for review August 8, 2024 11:09
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2024

see also #2312 :)

😭 😭 😭

Base automatically changed from fix/folders-empty to master August 8, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature technical debt Technical issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @susnux