[stable6] Backport of stable 6 for Nextcloud 26

[come-nc]

1. Fixed signature of beforeController method on the middleware
2. Allow 26 in info.xml
3. Replace attributes by annotations

This PR also includes the following PRs:

• [stable6] Perf improvements for stable-6 for 26 branch #3445
• [stable6] Backports of perf improvements for stable 6 on 26 #3446
• [stable6] reverse getToken() #3449
• [stable6] fix: Add visual loading feedback for polls list #3448
• [stable6] Default to "My polls" view #3451

[dartcafe]

nice. Now I remember the incompatibility. 😁

[dartcafe]

I updated the branch protection for stable-6

[come-nc]

nice. Now I remember the incompatibility. 😁

Do you think I missed anything? Do you know how complete are the unit tests?
I tested the UI a bit and it seems to work, but there is always the possibility of an incompatible signature in a corner-case code path.
Psalm seems happy so that’s good.

[dartcafe]

As soon as you are ready, add me as a reviewer. I will check then. Code wise it looks good.

[dartcafe]

I installed NC26 and will test some recent edge cases. But it may make sense to add the performance issues to the branch, so the stable-5 can die.

[dartcafe]

I did some smoke testing and did not find any flaws so far. So OK from me!

Do you know how complete are the unit tests?

The whole testing is very poor and would need some significant coverage increase. See #3147 😉

[come-nc]

• [stable6] Default to "My polls" view #3451 should be reverted
• master should be added back to phpunit and maybe psalm workflows
• Then merge 🎉

[dartcafe]

• [stable6] Default to "My polls" view #3451 should be reverted
  • see [stable-6] Revert #3451 #3468
• master should be added back to phpunit and maybe psalm workflows
  • Master is fine as it is, as well as the stable-6, or what do you have to do there?
• Then merge 🎉
  • Please merge, whenever you are ready to (also to stable-6 ??)

[dartcafe]

@come-nc @ChristophWurst What's about the open PRs? Aren't they superseeded and are to be closed?

• perf: Push Acl::getIsInvitedViaGroupShare type filtering to the db #3380
• perf: Cache \OCA\Polls\Model\Acl::getIsInvolved #3368
• perf: Determine participant status more efficiently #3364
• perf: Load poll options max timestamps eagerly #3363

[come-nc]

• Master is fine as it is, as well as the stable-6, or what do you have to do there?

You’re right master makes no sense, stable-6 is not compatible with Nextcloud master.
We could test with stable28 along with stable26 but I think testing the oldest supported version is enough for a stable version like this.

[come-nc]

• Please merge, whenever you are ready to (also to stable-6 ??)

I’m ready to merge, I just need your approval.

[dartcafe]

Approval already given. Ah. Needed approval again. Done.
What do you think about merging #3467 first to this branch?
It will help to reduce the poll loading time by half.

[come-nc]

What do you think about merging #3467 first to this branch?
It will help to reduce the poll loading time by half.

I think it’s cleaner to merge to stable-6.
This branch was meant as a temporary effort to test if supporting 26 was possible, now that it’s merged we can merge other things to stable-6 to keep improvements going.