Make adjustments based on the review

Co-authored-by: Louis Chemineau <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
nextcloud · Jul 19, 2023 · 343322f · 343322f
1 parent 4d28fe4
commit 343322f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 28 deletions.
diff --git a/lib/private/Notification/Action.php b/lib/private/Notification/Action.php
@@ -27,22 +27,16 @@
 use OCP\Notification\IAction;
 
 class Action implements IAction {
-	/** @var string */
 	protected string $label;
 
-	/** @var string */
 	protected string $labelParsed;
 
-	/** @var string */
 	protected string $link;
 
-	/** @var string */
 	protected string $requestType;
 
-	/** @var string */
 	protected string $icon;
 
-	/** @var bool */
 	protected bool $primary;
 
 	public function __construct() {

diff --git a/lib/private/Notification/Manager.php b/lib/private/Notification/Manager.php
@@ -64,7 +64,7 @@ class Manager implements IManager {
 	private bool $parsedRegistrationContext;
 
 	public function __construct(
-		protected IValidator      $validator,
+		protected IValidator $validator,
 		private IUserManager $userManager,
 		ICacheFactory $cacheFactory,
 		protected IRegistry $subscription,

diff --git a/lib/private/Notification/Notification.php b/lib/private/Notification/Notification.php
@@ -32,67 +32,46 @@
 use OCP\RichObjectStrings\IValidator;
 
 class Notification implements INotification {
-	/** @var string */
 	protected string $app;
 
-	/** @var string */
 	protected string $user;
 
-	/** @var \DateTime */
 	protected \DateTime $dateTime;
 
-	/** @var string */
 	protected string $objectType;
 
-	/** @var string */
 	protected string $objectId;
 
-	/** @var string */
 	protected string $subject;
 
-	/** @var array */
 	protected array $subjectParameters;
 
-	/** @var string */
 	protected string $subjectParsed;
 
-	/** @var string */
 	protected string $subjectRich;
 
-	/** @var array */
 	protected array $subjectRichParameters;
 
-	/** @var string */
 	protected string $message;
 
-	/** @var array */
 	protected array $messageParameters;
 
-	/** @var string */
 	protected string $messageParsed;
 
-	/** @var string */
 	protected string $messageRich;
 
-	/** @var array */
 	protected array $messageRichParameters;
 
-	/** @var string */
 	protected string $link;
 
-	/** @var string */
 	protected string $icon;
 
-	/** @var array */
 	protected array $actions;
 
-	/** @var array */
 	protected array $actionsParsed;
 
-	/** @var bool */
 	protected bool $hasPrimaryAction;
 
-	/** @var bool */
 	protected bool $hasPrimaryParsedAction;
 
 	public function __construct(