Skip to content

Commit

Permalink
Make adjustments based on the review
Browse files Browse the repository at this point in the history
Co-authored-by: Louis Chemineau <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
  • Loading branch information
shdehnavi and artonge committed Dec 11, 2023
1 parent c76c6c3 commit 576f5f6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
6 changes: 0 additions & 6 deletions lib/private/Notification/Action.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,16 @@
use OCP\Notification\IAction;

class Action implements IAction {
/** @var string */
protected string $label;

/** @var string */
protected string $labelParsed;

/** @var string */
protected string $link;

/** @var string */
protected string $requestType;

/** @var string */
protected string $icon;

/** @var bool */
protected bool $primary;

public function __construct() {
Expand Down
21 changes: 0 additions & 21 deletions lib/private/Notification/Notification.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,67 +32,46 @@
use OCP\RichObjectStrings\IValidator;

class Notification implements INotification {
/** @var string */
protected string $app;

/** @var string */
protected string $user;

/** @var \DateTime */
protected \DateTime $dateTime;

/** @var string */
protected string $objectType;

/** @var string */
protected string $objectId;

/** @var string */
protected string $subject;

/** @var array */
protected array $subjectParameters;

/** @var string */
protected string $subjectParsed;

/** @var string */
protected string $subjectRich;

/** @var array */
protected array $subjectRichParameters;

/** @var string */
protected string $message;

/** @var array */
protected array $messageParameters;

/** @var string */
protected string $messageParsed;

/** @var string */
protected string $messageRich;

/** @var array */
protected array $messageRichParameters;

/** @var string */
protected string $link;

/** @var string */
protected string $icon;

/** @var array */
protected array $actions;

/** @var array */
protected array $actionsParsed;

/** @var bool */
protected bool $hasPrimaryAction;

/** @var bool */
protected bool $hasPrimaryParsedAction;

public function __construct(
Expand Down

0 comments on commit 576f5f6

Please sign in to comment.