fix(carddav): limit vcard size

Signed-off-by: SebastianKrupinski <[email protected]>
nextcloud · Jul 4, 2024 · 600202f · 600202f
1 parent bc4e9e9
commit 600202f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/apps/dav/lib/CardDAV/Validation/CardDavValidatePlugin.php b/apps/dav/lib/CardDAV/Validation/CardDavValidatePlugin.php
@@ -29,7 +29,7 @@ public function initialize(Server $server): void {
 
 	public function beforePut(RequestInterface $request, ResponseInterface $response): bool {
 		// evaluate if card size exceeds defined limit
-		$cardSizeLimit = $this->config->getValueInt(Application::APP_ID, 'card_size_limit', 5242880);
+		$cardSizeLimit = (int) $this->config->getValue(Application::APP_ID, 'card_size_limit', '5242880');
 		if ((int) $request->getRawServerValue('CONTENT_LENGTH') > $cardSizeLimit) {
 			throw new Forbidden("VCard object exceeds $cardSizeLimit bytes");
 		}

diff --git a/apps/dav/tests/unit/CardDAV/Validation/CardDavValidatePluginTest.php b/apps/dav/tests/unit/CardDAV/Validation/CardDavValidatePluginTest.php
@@ -39,9 +39,9 @@ public function testPutSizeLessThenLimit(): void {
 
 		// construct method responses
 		$this->config
-			->method('getValueInt')
-			->with('dav', 'card_size_limit', 5242880)
-			->willReturn(5242880);
+			->method('getValue')
+			->with('dav', 'card_size_limit', '5242880')
+			->willReturn('5242880');
 		$this->request
 			->method('getRawServerValue')
 			->with('CONTENT_LENGTH')
@@ -57,9 +57,9 @@ public function testPutSizeMoreThenLimit(): void {
 
 		// construct method responses
 		$this->config
-			->method('getValueInt')
-			->with('dav', 'card_size_limit', 5242880)
-			->willReturn(5242880);
+			->method('getValue')
+			->with('dav', 'card_size_limit', '5242880')
+			->willReturn('5242880');
 		$this->request
 			->method('getRawServerValue')
 			->with('CONTENT_LENGTH')