Merge pull request #38176 from danialRahimy/master

Admin audit app: optimization according to PHP 8
nextcloud · Jul 5, 2023 · 79d24bf · 79d24bf
2 parents 86e7af1 + 91d50c5
commit 79d24bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/apps/admin_audit/lib/Actions/Action.php b/apps/admin_audit/lib/Actions/Action.php
@@ -31,12 +31,10 @@
 use OCA\AdminAudit\IAuditLogger;
 
 class Action {
-	/** @var IAuditLogger */
-	private $logger;
 
-	public function __construct(IAuditLogger $logger) {
-		$this->logger = $logger;
-	}
+	public function __construct(
+		private IAuditLogger $logger,
+	) {}
 
 	/**
 	 * Log a single action with a log level of info

diff --git a/apps/admin_audit/lib/BackgroundJobs/Rotate.php b/apps/admin_audit/lib/BackgroundJobs/Rotate.php
@@ -35,15 +35,12 @@
 class Rotate extends TimedJob {
 	use RotationTrait;
 
-	/** @var IConfig */
-	private $config;
-
-	public function __construct(ITimeFactory $time,
-								IConfig  $config) {
+	public function __construct(
+		ITimeFactory $time,
+		private IConfig $config,
+	) {
 		parent::__construct($time);
 
-		$this->config = $config;
-
 		$this->setInterval(60 * 60 * 3);
 	}