Refactors "strpos" calls in /apps/settings #38606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
icewind1991
approved these changes
Jun 3, 2023
Signed-off-by: Faraz Samapoor <[email protected]>
come-nc
force-pushed
the
replace_strpos_calls_in_settings_app
branch
from
2f7421c
to
ff0b3fe
Compare
|
conflicts |
szaimen
added
2. developing
Signed-off-by: Faraz Samapoor <[email protected]>
|
@szaimen Resolved. |
szaimen
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #38261 and #38260, I have replaced
strposcalls in/apps/settingsnamespace as well to improve code readability.