Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[f2v] Favorites view #38950

Merged
merged 19 commits into from
Jul 5, 2023
Merged

[f2v] Favorites view #38950

merged 19 commits into from
Jul 5, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 22, 2023

Supersede #37727
Fix #7627

  • Tests
  • Remove old favorite view when ready
  • Backport 1fd2258 to stable27

@skjnldsv skjnldsv changed the title feat(files): favorites [f2v] Favorites view Jun 22, 2023
Base automatically changed from feat/f2v/more-actions to master June 22, 2023 20:08
@skjnldsv skjnldsv force-pushed the feat/f2v/favorites branch 3 times, most recently from 7388da3 to dc7cc3e Compare June 30, 2023 12:34
@skjnldsv skjnldsv requested review from a team, susnux, Fenn-CS, Pytal and artonge and removed request for a team June 30, 2023 12:34
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 30, 2023
@skjnldsv skjnldsv force-pushed the feat/f2v/favorites branch 4 times, most recently from 8ea110f to 3170e08 Compare July 4, 2023 15:58
@skjnldsv skjnldsv force-pushed the feat/f2v/favorites branch 2 times, most recently from 28d05b5 to ece00b3 Compare July 5, 2023 14:41
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@skjnldsv skjnldsv merged commit 6862ff2 into master Jul 5, 2023
37 checks passed
@skjnldsv skjnldsv deleted the feat/f2v/favorites branch July 5, 2023 16:27
apps/files/src/views/favorites.ts Outdated Show resolved Hide resolved
apps/files/src/components/FileEntry.vue Show resolved Hide resolved
apps/files/src/actions/favoriteAction.ts Outdated Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Jul 12, 2023
6 tasks
@skjnldsv
Copy link
Member Author

/backport 28c2d9e to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add multiple files to favorites
4 participants