-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(sab): Add profileUrl to SAB #38969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesGGE
added
enhancement
feature: dav
integration
feature: profile
PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
feature: carddav
Related to CardDAV internals
labels
Jun 23, 2023
tcitworld
reviewed
Jun 23, 2023
JohannesGGE
force-pushed
the
enh/38944/add-profile-url-to-sab
branch
from
June 26, 2023 08:47
38d311a
to
3388a34
Compare
tcitworld
reviewed
Jun 26, 2023
JohannesGGE
force-pushed
the
enh/38944/add-profile-url-to-sab
branch
2 times, most recently
from
June 26, 2023 12:08
28d6ced
to
15ca794
Compare
ChristophWurst
approved these changes
Jun 26, 2023
You get bonus point for adjusting https://github.com/nextcloud/server/blob/master/apps/dav/tests/unit/CardDAV/ConverterTest.php ;) The test can be run with |
miaulalala
approved these changes
Jun 27, 2023
The test fails and has to be adjusted |
JohannesGGE
force-pushed
the
enh/38944/add-profile-url-to-sab
branch
from
June 27, 2023 12:27
15ca794
to
cc93c7b
Compare
ChristophWurst
approved these changes
Jun 27, 2023
JohannesGGE
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jul 3, 2023
Signed-off-by: Johannes Merkel <[email protected]>
JohannesGGE
force-pushed
the
enh/38944/add-profile-url-to-sab
branch
from
July 3, 2023 15:55
cc93c7b
to
eda3824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: carddav
Related to CardDAV internals
feature: dav
feature: profile
PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
integration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist