Refactors dav app commands. #39166
Merged
Refactors dav app commands. #39166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @szaimen, sorry to bother you. |
szaimen
requested review from
ChristophWurst,
miaulalala,
skjnldsv,
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
fsamapoor
force-pushed
the
refactor_dav_app_commands
branch
from
443c32e
to
1ea5d43
Compare
|
Conflicts resolved. |
ChristophWurst
approved these changes
Sep 11, 2023
miaulalala
approved these changes
Sep 11, 2023
icewind1991
approved these changes
Sep 20, 2023
|
Hey @icewind1991, Saw the retriggered failed workflows and I wanted to let you know It's been more than a month now that not a single pull request of mine has been able to pass the Cypress workflows. |
|
I will rebase the branch - if you want to do some additional work, you will need to pull first @fsamapoor |
miaulalala
force-pushed
the
refactor_dav_app_commands
branch
from
1ea5d43
to
5b6e419
Compare
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_dav_app_commands
branch
from
5b6e419
to
d13874f
Compare
No additional work is needed. I just rebased it again to pass the failed DCO workflow. |
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have made some adjustments to the
apps/dav/lib/Commandclasses to improve the code readability.The improvements in this PR include but are not limited to:
Checklist