Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better untested app button's wording #39201

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Jul 6, 2023

Replace "Enable untested app" with "Authorize this untested app".

"Enable" creates confusion because when you click on this button, you only allow installing it ... and then it makes the install button appear ... and finally, the app is automatically enabled after install.

Checklist

Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
@@ -42,9 +42,9 @@ export default {
},
forceEnableButtonText() {
if (this.app.needsDownload) {
return t('settings', 'Enable untested app')
return t('settings', 'Authorize this untested app')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Activate this untested app ? cc @nextcloud/designers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, "Activate" is a synonym of "Enable". What about "Allow". Otherwise, why don't you like "Authorize". I think we should keep away from the "enable" (or activate) notion. What do you think ?

@nimishavijay
Copy link
Member

Definitely an improvement! I'm thinking it may be better to just get rid of the 2 steps, so authorize and automatically start the download action when the "Enable untrusted app" button is clicked. What do you think?

@Jerome-Herbinet
Copy link
Member Author

Definitely an improvement! I'm thinking it may be better to just get rid of the 2 steps, so authorize and automatically start the download action when the "Enable untrusted app" button is clicked. What do you think?

"untrusted" is IMO too discriminant … and may let the user think that the whole app (whatever the version) is untrusted. Do you have another suggestion ?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world I would say @nimishavijay’s suggestion of a single-step process is great, but I assume this would take a lot more work.

So I would say @Jerome-Herbinet the best call is to adjust the wording to "Allow untested app". Short and still different from pressing "Enable …" 2 times.

Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet
Copy link
Member Author

New PR #39575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants