Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable download configuration on circles shares #39693

Merged

Conversation

ArtificialOwl
Copy link
Member

we can re-enable the download configuration on shares to Circles, as the feature is now managed by the app: nextcloud/circles#1357

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/manage-download-settings-on-circles-share branch from 4ce5127 to 014d207 Compare August 7, 2023 11:04
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/manage-download-settings-on-circles-share branch from 014d207 to d18a1f4 Compare September 2, 2023 14:11
@joshtrichards joshtrichards added 3. to review Waiting for reviews feature: circles Related to circles labels Sep 5, 2023
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/manage-download-settings-on-circles-share branch from d18a1f4 to 4e2d6b5 Compare September 5, 2023 13:12
@ArtificialOwl ArtificialOwl merged commit 0409ae0 into master Sep 5, 2023
41 checks passed
@ArtificialOwl ArtificialOwl deleted the enh/noid/manage-download-settings-on-circles-share branch September 5, 2023 17:07
@ArtificialOwl
Copy link
Member Author

/backport to stable27

@ArtificialOwl
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request feature: circles Related to circles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants