feat(caldav): Create personal event for out-of-office messages #41340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Nov 8, 2023
Merged
ChristophWurst
added
feature: dav
integration
feature: caldav
ChristophWurst
commented
Nov 10, 2023
ChristophWurst
added
pending documentation
miaulalala
requested changes
Nov 14, 2023
|
You can leave as is except for the PRODID. |
miaulalala
requested changes
Nov 14, 2023
| $vCalendar->add($vtimezone); | ||
|
|
||
| /** @psalm-suppress UndefinedMethod */ | ||
| $vEvent->DTSTART->setDateTime($start->setTimezone($calendarTimeZone)->setTime(0, 0)); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| /** @psalm-suppress UndefinedMethod */ | ||
| $vEvent->DTSTART->setDateTime($start->setTimezone($calendarTimeZone)->setTime(0, 0)); | ||
| /** @psalm-suppress UndefinedMethod */ | ||
| $vEvent->DTEND->setDateTime($end->setTimezone($calendarTimeZone)->setTime(0, 0)); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
miaulalala
approved these changes
Nov 14, 2023
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
feat/caldav/ooo-event
branch
from
86f50b6
to
5b7a547
Compare
| @@ -70,8 +71,10 @@ | |||
| if ($user->getUID() !== $this->getUserId()) { | |||
| throw new InvalidArgumentException("The user doesn't match the user id of this absence! Expected " . $this->getUserId() . ", got " . $user->getUID()); | |||
| } | |||
| if ($this->getId() === null) { | |||
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
AndyScherzinger
approved these changes
Nov 14, 2023
4 tasks
|
@ChristophWurst #42142 made me notice I had never submitted my review. Added two comments directly on commit itself since I can't post it anymore. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create and maintain an event in a user's personal calendar when they configure an out of office message.
TODO
Checklist