fix(user_ldap): Ignore unserialize error in group membership migration #43764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/user_ldap-ignore-unserialize-errors-in-migration
branch
from
0e53304
to
301e23b
Compare
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
|
/backport to stable28 |
icewind1991
approved these changes
Mar 5, 2024
Altahrim
approved these changes
Mar 5, 2024
The memberships will be checked by the background job later and data will be added to the table anyway. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/user_ldap-ignore-unserialize-errors-in-migration
branch
from
301e23b
to
875d0a2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldap_group_memberstable #43584Summary
The memberships will be checked by the background job later and data will be added to the table anyway.
This avoids blocking migration when there is invalid data in the ldap_group_members table, whatever the reason.
Checklist