Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AES Encryption/Decryption for User Login Credentials #47145

Closed
wants to merge 2 commits into from

Conversation

Anyel-ec
Copy link

@Anyel-ec Anyel-ec commented Aug 9, 2024

No description provided.

@kesselb
Copy link
Contributor

kesselb commented Aug 9, 2024

Hi and thanks for your pull request 👍

I'm confused by the pull request description. Everything you listed under "Changes" was already there?

Your pull request contains plenty of unrelated changes (e.g. adding an unused dependency, reformatting of files, removing of copyright headers). That makes reviewing your changes unnecessarily complicated.

Todos:

  • Restore the copyright headers
  • Remove the debugging code (the commented echos, init_set, error_reporting, etc.)
  • Remove the unused/duplicate dependency (phpseclib is already a nextcloud dependency, see https://github.com/nextcloud/3rdparty/)
  • Revert the unrelated changes (e.g., newlines, reformatting of files, etc.)
  • Fix the failing unit tests

If the pull request is in a reviewable state, I can forward it to our security people.

@kesselb kesselb added enhancement 2. developing Work in progress labels Aug 9, 2024

encrypt(data) {
// Generar clave y IV
const secretKey = 'my-secret-key'; // Clave en hexadecimal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What security benefit should this bring? The key is known so it is basically just (revertable) hiding the data if you sniff the packages. But meaning it does not add any security?

@Anyel-ec Anyel-ec closed this by deleting the head repository Aug 12, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants