Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix non-sticky sticky views in files nav #47207

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 13, 2024

Resolves

Before After
image image

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Aug 13, 2024
@Pytal Pytal self-assigned this Aug 13, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner August 13, 2024 23:04
@Pytal Pytal enabled auto-merge August 13, 2024 23:04
@skjnldsv
Copy link
Member

/compile rebase-amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 14, 2024
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv disabled auto-merge August 14, 2024 07:34
@skjnldsv skjnldsv merged commit 73c8891 into master Aug 14, 2024
102 of 109 checks passed
@skjnldsv skjnldsv deleted the fix/sticky-nav-item branch August 14, 2024 07:34
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Deleted files" went from being sticky on the bottom of the nav to last item in the nav list
4 participants