Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Limit valid avatar sizes #47211

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

provokateurin
Copy link
Member

Summary

The code already limits the sizes to 64 and 512, so it can be properly documented for the API too.
The change from string to int in the GuestAvatarController is not a breaking change because the parameters is part of the path and thus always serialized the same regardless if it is a string or an int.

Checklist

@skjnldsv skjnldsv requested a review from a team August 14, 2024 07:56
@skjnldsv skjnldsv merged commit 2c7f5dc into master Aug 14, 2024
169 checks passed
@skjnldsv skjnldsv deleted the fix/core/limit-valid-avatar-sizes branch August 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants