Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: try to find non-recursive share source #47280

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 16, 2024

Backport of #46881

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <[email protected]>
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Operand of type false is always falsy
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Docblock-defined type OCP\Files\Storage\IStorage for $this->nonMaskedStorage is never falsy
@AndyScherzinger AndyScherzinger merged commit 15c98cb into stable27 Aug 16, 2024
41 of 43 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/46881/stable27 branch August 16, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants