Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Access node owner by top level owner property #47287

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 16, 2024

Summary

As suggested by @skjnldsv in the previous PR we should not use owner-id directly but just use the top level owner attribute (which will be set to owner-id anyways by default).
This fixes the mentioned issue, moreover I added some tests for the inline status action and a regression test for this bug.

(We nevertheless should fix the wrong type of the owner-id attribute in davResultToNode and cast it to string, but we can do so later in @nextcloud/files)

Checklist

@susnux
Copy link
Contributor Author

susnux commented Aug 16, 2024

/backport to stable30

@@ -69,7 +67,7 @@ export const action = new FileAction({
}

// Group shares
if (shareTypes.includes(ShareType.Grup)
if (shareTypes.includes(ShareType.Group)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good one 😅🙈

@skjnldsv
Copy link
Member

files_sharing: Files inline status action
    (Attempt 1 of 3) No "shared" tag when user ID is purely numerical
    (Attempt 2 of 3) No "shared" tag when user ID is purely numerical
    1) No "shared" tag when user ID is purely numerical
    ```

@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2024

@skjnldsv

files_sharing: Files inline status action

Happens because Cypress does not compile the sources before testing -> So it fails like it does on master. As soon as we compile it will work here. (No idea why the compile step was removed from cypress?)

@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2024

/compile

susnux and others added 2 commits August 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants