fix: FilenameValidator::isForbidden should only check forbidden files
#47372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Altahrim,
yemkareems,
provokateurin and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
susnux
force-pushed
the
fix/filename-validator
branch
from
a40f8de
to
58ac74b
Compare
And not forbidden basenames as this is used for different purposes. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/filename-validator
branch
from
58ac74b
to
b9cc7bc
Compare
… files. Signed-off-by: Ferdinand Thiessen <[email protected]>
provokateurin
approved these changes
Aug 21, 2024
sorbaugh
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createandupdate#47185Summary
FilenameValidator::isForbiddenshould only check forbidden files and not forbidden basenames as this is used for different purposes.Checklist