fix(css): make scrollbar visible again #47617
Conversation
There was a problem hiding this comment.
I agree that the current scrollbar is not very accessible.
So I fully support removing the scrollbar-width, but for the scrollbar-color I think we should use theming.
The color is broken it should be var(--color-border-maxcontrast) transparent and for our high-contrast themes we should set it to auto.
But would also be fine with removing the styles for the scrollbar if designers agree with that :)
Before
Bildschirmaufnahme_20240830_031750.webm
After (this PR)
Bildschirmaufnahme_20240830_031648.webm
There was a problem hiding this comment.
@susnux Good point with using color-text-maxcontrast for the scrollbar color. @Ornanovitch could you adjust that?
Otherwise it looks good. :)
|
Thanks a lot for this quick review! I'm fine with the theming, I will adjust in a few hours :) And thx for the screen-casts @susnux, I'll try to figure out how to make those easily |
Ornanovitch
force-pushed
the
ornano/scrollbar-visibility
branch
from
87d91c3
to
65c4394
Compare
There was a problem hiding this comment.
Awesome, thank you @Ornanovitch!
Btw, are you already in our Design room (link on https://nextcloud.com/design ) – I can also give you a guest account if you don't have one yet.
And are you aware of our Community Conference in Berlin? :) https://nextcloud.com/conf
|
The pleasure is all mine, I'd love to work on the Nextcloud design from time to time :)
I'm not, let's go!
I'll check this out :) Thanks again! |
Signed-off-by: protoclown <[email protected]>
Signed-off-by: protoclown <[email protected]>
Signed-off-by: protoclown <[email protected]>
Signed-off-by: protoclown <[email protected]>
susnux
force-pushed
the
ornano/scrollbar-visibility
branch
from
588c4c2
to
b711da7
Compare
|
@Ornanovitch could you please run |
Signed-off-by: protoclown <[email protected]>
|
done! |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Nice work @Ornanovitch - sent you an invite to the Github organization of Nextcloud so you don't need to work via a fork for contributions. Should make life easier for you 👍 Thanks for your work on the fix 💯 |
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47617/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick afc4940f d1f82e7f df7db817 b711da73 15e449a7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47617/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..87f8a8c
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
@Ornanovitch awesome, you should get an email with the details for the account. :) Added you to the "Design team" chat already. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Let the browser do its job regarding the appearance of the scrollbar
Sorry for the two unrelated changes, my neovim doesn't love trailing spaces 😸
Checklist