Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make user removal more resilient #47896

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: Make user removal more resilient #47896

merged 2 commits into from
Oct 7, 2024
+328 −85

Commits on Sep 26, 2024

  1. fix: Make user removal more resilient 

    Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    16833af View commit details
    Browse the repository at this point in the history

  2. fix: Skip users that still exist in backend 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d57a2dd View commit details
    Browse the repository at this point in the history