fix(CI): Fix psalm by changing the addHeader() calls

Signed-off-by: Joas Schilling <[email protected]>
nextcloud · Jul 24, 2023 · 9408c01 · 9408c01
1 parent 6034c03
commit 9408c01
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/Controller/ChatController.php b/lib/Controller/ChatController.php
@@ -430,8 +430,8 @@ protected function prepareCommentsAsDataResponse(array $comments, int $lastCommo
 					// Set the status code to 200 so the header is sent to the client.
 					// As per "section 10.3.5 of RFC 2616" entity headers shall be
 					// stripped out on 304: https://stackoverflow.com/a/17822709
-					$response->setStatus(Http::STATUS_OK);
 					$response->addHeader('X-Chat-Last-Common-Read', (string) $newLastCommonRead);
+					$response->setStatus(Http::STATUS_OK);
 				}
 			}
 			return $response;

diff --git a/lib/Controller/RoomController.php b/lib/Controller/RoomController.php
@@ -220,9 +220,10 @@ public function getRooms(int $noStatusUpdate = 0, bool $includeStatus = false, i
 			}
 		}
 
-		$response = new DataResponse($return, Http::STATUS_OK, $this->getTalkHashHeader());
-		$response->addHeader('X-Nextcloud-Talk-Modified-Before', (string) $nextModifiedSince);
-		return $response;
+		$headers = $this->getTalkHashHeader();
+		$headers['X-Nextcloud-Talk-Modified-Before'] = (string) $nextModifiedSince;
+
+		return new DataResponse($return, Http::STATUS_OK, $headers);
 	}
 
 	/**