Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): expand system messages group if visual unread marker is set on it #11063

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 1, 2023

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before (need to click) 🏡 After (already open)
Screenshot from 2023-12-01 11-34-31 Screenshot from 2023-12-01 11-54-59

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 1, 2023
@Antreesy Antreesy self-assigned this Dec 1, 2023
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solved the issue :) but one thing ( not sure about its complexity) :

The VisualLastReadMessageId is updated after navigating to the conversation for the second time but it also takes a short period to update. This makes the group uncollapsed for the second time too because it caught the initial value of the last read message Id.

I think it should not follow the last read message Id but what that id follows in the first place. From first check, seen in Message can be a good candidate but I am not sure.

@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 1, 2023

From first check, seen in Message can be a good candidate but I am not sure.

Originally, it should be conversation.lastReadMessage, but need to check if it covers system messages

UPD: yes, it covers

@Antreesy Antreesy force-pushed the fix/10758/expand-unread-system-messages branch from f06f6b8 to 0a9c2b2 Compare December 1, 2023 13:23
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Ready to go 🦅

@Antreesy Antreesy merged commit 2fbcaf2 into main Dec 1, 2023
36 checks passed
@Antreesy Antreesy deleted the fix/10758/expand-unread-system-messages branch December 1, 2023 14:59
@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 1, 2023

/backport to stable28

@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 1, 2023

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-up(SystemMessageGroup) - improve behaviour
2 participants