Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(directive): unify tooltip registration #12358

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(directive): unify tooltip registration #12358

merged 2 commits into from
May 15, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Ref Vue 3 Migration #9448
  • Unify usage of tooltips across the app
  • Remove the global registration of tooltip added in MatterbridgeSettings
  • Remove outdated / no longer used imports

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone May 15, 2024
@Antreesy Antreesy self-assigned this May 15, 2024
@Antreesy Antreesy merged commit 8beb15f into main May 15, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/register-tooltip branch May 15, 2024 12:38
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme