fix(Call): introduce intermediary phase before joining call #13329
Conversation
| setTimeout(() => { | ||
| // If by accident we never receive a users list, just switch to | ||
| // "Waiting for others to join the call …" after some seconds. | ||
| commit('finishedConnecting', { token, sessionId: participantIdentifier.sessionId }) | ||
| }, 10000) |
There was a problem hiding this comment.
It's guaranteed to receive one of the above signaling events as we are the base server
There was a problem hiding this comment.
Note that finishedConnecting does not mean It was possible to join the call, but After joining the call, the list of participants in the call was received. Therefore this change breaks its behaviour.
After joining a call without HPB Connecting was shown in the call view until the list of participants in the call was received. If there were no other participants in the call Connecting was replaced by Waiting for others to join the call, and if there were other participants then a connection was established with them. Now, if there are other participants, Waiting for others to join the call will be briefly shown until the participant list is received, which is not correct.
If there is HPB, however, the Connecting state was wrong, as usersInRoom is never triggered in that case (probably usersChanged should have been used instead) 🤷 So Connecting was shown for ten seconds when there were no other participants in the call.
|
…t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining Signed-off-by: DorraJaouad <[email protected]>
…nCall, connecting, connection failed) Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
f700fed
to
1191f69
Compare
It was because |
…roduce a failed join message dialog. Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
1191f69
to
40205de
Compare
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Before
Recording.2024-09-17.160718.mp4
After
Recording.2024-09-17.160913.mp4
🏁 Checklist