Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chat): import mdi icons #13340

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(chat): import mdi icons #13340

wants to merge 2 commits into from
+4 −11

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 18, 2024 •
edited
Loading

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme
chore(deps): add @mdi/js
95586df 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
refactor(chat): import mdi icons
37911dc 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme added this to the 🖤 Next Major (31) milestone Sep 18, 2024
@ShGKme ShGKme self-assigned this Sep 18, 2024
@Antreesy
Copy link
Contributor

Antreesy commented Sep 19, 2024 •
edited
Loading

Is it correctly tree-shakes the lib? I thought about that, but didn't want to add a 3Mb library just for 7 strings

@ShGKme ShGKme marked this pull request as draft September 19, 2024 14:39
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 19, 2024

Is it correctly tree-shakes the lib? I thought about that, but didn't want to add a 3Mb library just for 7 strings

Hmm... It must work fine, and on server it does. But in Talk it doesn't, and I do not understand, why

@nickvergessen
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@Antreesy Antreesy Awaiting requested review from Antreesy

At least 1 approving review is required to merge this pull request.

Assignees

@ShGKme ShGKme

Labels
3. to review backport-request feature: chat 💬 Chat and system messages technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @Antreesy @nickvergessen