Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audioPlayer): Auto play voice messages which are grouped together #13360

Merged

Conversation

Souptik2001
Copy link
Contributor

@Souptik2001 Souptik2001 commented Sep 20, 2024

☑️ Resolves

Note: In Whatsapp (whose example is given in the issue), the voice messages auto-play only when they are grouped together. Therefore I tried to replicate that only. If there's a message between two voice messages, it will not be auto-played.
That being said, its very easy to change this behaviour. We just need to remove this since check over here.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Before

Before.mov

After

After.mov

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution!
I see the current implementation a bit overcomplicated, please see comments

@Antreesy
Copy link
Contributor

Hi, just tested the PR. Works nice!

Also looks good code-wise, left a fixup commit to reduce unneccessary changes. Waiting for @DorraJaouad approval, then we can squash and merge it.

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 25, 2024
@Antreesy Antreesy self-assigned this Sep 25, 2024
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅
Code-wise ✅

@Antreesy Antreesy force-pushed the feat/13199/auto-play-voice-messages branch from 4ef10eb to adf1b62 Compare September 25, 2024 18:12
@Antreesy Antreesy merged commit 6283abf into nextcloud:main Sep 25, 2024
46 checks passed
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let audio recordings play after each other
3 participants