Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show two promoted videos #13458

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 2, 2024

☑️ Resolves

  • PresenterOverlay broke v-else-if chain in previous place
  • also add distinct keys to prevent rendering issues

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

- PresenterOverlay broke v-else-if flow in previous place
- also add distinct keys to prevent rendering issues

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 2, 2024
@Antreesy Antreesy self-assigned this Oct 2, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 2, 2024

/backport to stable30

@Antreesy Antreesy merged commit 1127cde into main Oct 2, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/call-view-rendering branch October 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants