Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up(ChatView) - align scroll button position with mobile clients #9861

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 26, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-06-26 11-50-23 image
Screenshot from 2023-06-26 11-50-29 image

🚧 Tasks

  • Visual check / Testing
  • Code review

🏁 Checklist

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the button should be within the boundaries of the message list, with 8px bottom margin to the new message form component

@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 30, 2023

I think the button should be within the boundaries of the message list, with 8px bottom margin to the new message form component

You mean to lift it up on 8px, not lower? For now I restored it's initial position, so it will be a design change.
And as you came up with this suggestion, maybe we also should replace icon with double chevron, like on Android? https://pictogrammers.com/library/mdi/icon/chevron-double-down/
Screenshot_2023-06-30-08-02-53-901-edit_com.nextcloud.talk2.jpg

@marcoambrosini
Copy link
Member

Icon change sounds good. I mean exactly like the screenshot you posted, ~ 8px above the newmessageform border.

@Antreesy Antreesy changed the title follow-up(ChatView) - restore scroll button position follow-up(ChatView) - align scroll button position with mobile clients Jun 30, 2023
@Antreesy Antreesy merged commit 80aafa6 into master Jun 30, 2023
18 checks passed
@Antreesy Antreesy deleted the fix/9826/adjust-scroll-button branch June 30, 2023 09:33
@Antreesy
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants