Refactor lib [Part2] #9994
Closed
Refactor lib [Part2] #9994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamid Dehnavi <[email protected]>
nickvergessen
requested changes
Jul 17, 2023
nickvergessen
added
2. developing
technical debt
feature: api 🛠️
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
|
Tests are failing and types are still not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The required adjustments have been made to the following namespaces:
/lib/Command/lib/Controller/lib/Deck/lib/EventsThe improvements:
strposwithstr_starts_withto improve code readability🏁 Checklist
docs/has been updated or is not required