fix(info.xml) Prevent installation in 32-bit environments #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a dependency (used for IPv6 handling) requires a 64-bit environment, prevent this app from being installed in 32-bit environments in order to avoid Composer's `php-64bit` enforcement from kicking in and triggering nextcloud/server#43157. While `php-64bit` has always been place, Composer only recently started enforcing it in composer/composer#11334 apparently so this wasn't a problem until now. This fix provides a proper preventative measure we can control until when/if this app is okay for 32-bit environments. Signed-off-by: Josh <[email protected]>
joshtrichards
requested review from
ChristophWurst,
marcelklehr and
st3iny
as code owners
This was referenced Jan 30, 2024
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
Superseded by #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a dependency (used for IPv6 handling) requires a 64-bit environment, prevent this app from being installed in 32-bit environments in order to avoid Composer's
php-64bitenforcement from kicking in and triggering nextcloud/server#43157. While we already hadphp-64bitin place in our Composer config, Composer only recently started enforcing it in composer/composer#11334 apparently so this wasn't a problem until now.This fix provides a proper preventative measure (and one we can control) until when/if this app is okay for 32-bit environments.
Fixes nextcloud/server#43157